doc(Home): update link address #6520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideWrap community footer labels in anchor tags linking to the appropriate GitHub pages and adjust the homepage header spacing by incorporating the header height in CSS. Class diagram for updated HomeLayout footer linksclassDiagram
class HomeLayout {
+Render CommunityLi2 as anchor to https://github.com/BootstrapBlazor/membership/issues
+Render CommunityLi1 as anchor to https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme
+Render CommunityLi3 as anchor to https://github.com/dotnetcore/BootstrapBlazor/issues
}
Class diagram for updated Index page CSS variablesclassDiagram
class IndexPageCSS {
--bd-pink-rgb
--bd-violet-rgb
--bd-accent-rgb
--bs-header-height
+padding-top: calc(3rem + var(--bs-header-height))
+margin-top: calc(0px - var(--bs-header-height))
+background-image
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Layout/HomeLayout.razor:50` </location>
<code_context>
<ul>
<li>
- <div class="footer-link">@Localizer["CommunityLi2"]</div>
+ <div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank">@Localizer["CommunityLi2"]</a></div>
</li>
<li>
</code_context>
<issue_to_address>
Consider adding rel="noopener noreferrer" to external links with target="_blank".
This helps prevent the new tab from accessing the original window and reduces phishing risks.
Suggested implementation:
```
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi1"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi3"]</a></div>
```
</issue_to_address>
### Comment 2
<location> `src/BootstrapBlazor.Server/Components/Layout/HomeLayout.razor:53` </location>
<code_context>
</li>
<li>
- <div class="footer-link">@Localizer["CommunityLi1"]</div>
+ <div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank">@Localizer["CommunityLi1"]</a></div>
</li>
<li>
</code_context>
<issue_to_address>
Add rel="noopener noreferrer" to external anchor tags with target="_blank".
This helps prevent security vulnerabilities when opening links in new tabs.
Suggested implementation:
```
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi1"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi3"]</a></div>
```
</issue_to_address>
### Comment 3
<location> `src/BootstrapBlazor.Server/Components/Layout/HomeLayout.razor:56` </location>
<code_context>
</li>
<li>
- <div class="footer-link">@Localizer["CommunityLi3"]</div>
+ <div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank">@Localizer["CommunityLi3"]</a></div>
</li>
</ul>
</code_context>
<issue_to_address>
Include rel="noopener noreferrer" for all target="_blank" links.
This helps prevent security vulnerabilities when opening external links.
Suggested implementation:
```
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi1"]</a></div>
```
```
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi3"]</a></div>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <ul> | ||
| <li> | ||
| <div class="footer-link">@Localizer["CommunityLi2"]</div> | ||
| <div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank">@Localizer["CommunityLi2"]</a></div> |
Contributor
There was a problem hiding this comment.
🚨 suggestion (security): Consider adding rel="noopener noreferrer" to external links with target="_blank".
This helps prevent the new tab from accessing the original window and reduces phishing risks.
Suggested implementation:
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi1"]</a></div>
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi3"]</a></div>
| </li> | ||
| <li> | ||
| <div class="footer-link">@Localizer["CommunityLi1"]</div> | ||
| <div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank">@Localizer["CommunityLi1"]</a></div> |
Contributor
There was a problem hiding this comment.
🚨 suggestion (security): Add rel="noopener noreferrer" to external anchor tags with target="_blank".
This helps prevent security vulnerabilities when opening links in new tabs.
Suggested implementation:
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
<div class="footer-link"><a href="https://github.com/BootstrapBlazor/membership/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi2"]</a></div>
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor?tab=coc-ov-file#readme" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi1"]</a></div>
<div class="footer-link"><a href="https://github.com/dotnetcore/BootstrapBlazor/issues" target="_blank" rel="noopener noreferrer">@Localizer["CommunityLi3"]</a></div>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6520 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31387
Branches 4431 4430 -1
=========================================
Hits 31387 31387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6519
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update community footer links to actual URLs and adjust home page header spacing to accommodate the header height
Bug Fixes:
Enhancements: